Repository navigation
Conversation
github-actions
Bot
changed the base branch from
main
to
mikeflame/advisory-improvement-10478
October 21, 2026 18:33
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The metadata changes match the upstream fix and release notes, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates the fast-jwt advisory to identify the patched release for unknown crit header handling.
Changes:
- Records
6.2.0as the fixed version. - Adds references to the upstream fix commit and release notes.
| File | Description |
|---|---|
| advisories/github-reviewed/2026/04/GHSA-hm7r-c7qw-ghp6/GHSA-hm7r-c7qw-ghp6.json | Corrects the version range and adds supporting references. |
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The record says
<= 6.1.0with no patched version. The maintainers' repository advisory lists6.2.0as patched, and the code and the published package agree. The global record was last modified on 2026-04-06, before the fix was merged and 6.2.0 was released on 2026-04-07, so the patched version was not picked up.verifyTokengoes straight from the signature check to thetypcheck.src/verifier.jshas nocrithandling at all: https://github.com/nearform/fast-jwt/blob/v6.1.0/src/verifier.js#L177-L202validateCrit, which rejects anycritentry that is not in the newallowedCritHeadersoption (empty by default) and also rejects empty or non-arraycrit, registered header names and duplicates: https://github.com/nearform/fast-jwt/blob/v6.2.0/src/verifier.js#L192-L233validateCritis called fromverifyTokenright after the signature check: https://github.com/nearform/fast-jwt/blob/v6.2.0/src/verifier.js#L252-L253. Both the sync path and the async key-callback path go throughverifyToken: https://github.com/nearform/fast-jwt/blob/v6.2.0/src/verifier.js#L384 and https://github.com/nearform/fast-jwt/blob/v6.2.0/src/verifier.js#L426git merge-base --is-ancestorshows 80b49c7 is not in the v6.1.0 tag and is in v6.2.0 (release notes: https://github.com/nearform/fast-jwt/releases/tag/v6.2.0).src/verifier.jsin the npm tarballs of 6.1.0 and 6.2.0 is identical to the matching tag.I ran the advisory's PoC against the published npm packages. As written, the PoC passes
headerinside the payload, socritends up as a payload claim and every version accepts the token. Withcritin the signer'sheaderoption instead (so it is in the JOSE header, as in the fix's own test at https://github.com/nearform/fast-jwt/blob/v6.2.0/test/verifier.spec.js#L1783-L1795), the results are:FAST_JWT_INVALID_CRIT_HEADER)FAST_JWT_INVALID_CRIT_HEADER)A token without
critis still accepted by all three versions.