Skip to content

[GHSA-hm7r-c7qw-ghp6] fast-jwt accepts unknown crit header extensions (RFC 7515 violation) - #10478

Open
mikeflame wants to merge 1 commit into
mikeflame/advisory-improvement-10478from
mikeflame-GHSA-hm7r-c7qw-ghp6
Open

mikeflame wants to merge 1 commit into
mikeflame/advisory-improvement-10478from
mikeflame-GHSA-hm7r-c7qw-ghp6

Conversation

@mikeflame

Copy link
Copy Markdown

Updates

  • Affected products
  • References

Comments
The record says <= 6.1.0 with no patched version. The maintainers' repository advisory lists 6.2.0 as patched, and the code and the published package agree. The global record was last modified on 2026-04-06, before the fix was merged and 6.2.0 was released on 2026-04-07, so the patched version was not picked up.

I ran the advisory's PoC against the published npm packages. As written, the PoC passes header inside the payload, so crit ends up as a payload claim and every version accepts the token. With crit in the signer's header option instead (so it is in the JOSE header, as in the fix's own test at https://github.com/nearform/fast-jwt/blob/v6.2.0/test/verifier.spec.js#L1783-L1795), the results are:

fast-jwt sync verifier sync verifier with cache async key verifier
6.1.0 accepted accepted accepted
6.2.0 rejected (FAST_JWT_INVALID_CRIT_HEADER) rejected rejected
6.3.3 (latest) rejected (FAST_JWT_INVALID_CRIT_HEADER) rejected rejected

A token without crit is still accepted by all three versions.

Copilot AI max review requested due to automatic review settings October 21, 2026 18:33
@github-actions
github-actions Bot changed the base branch from main to mikeflame/advisory-improvement-10478 October 21, 2026 18:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The metadata changes match the upstream fix and release notes, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Updates the fast-jwt advisory to identify the patched release for unknown crit header handling.

Changes:

  • Records 6.2.0 as the fixed version.
  • Adds references to the upstream fix commit and release notes.
File Description
advisories/​github-reviewed/​2026/​04/​GHSA-hm7r-c7qw-ghp6/​GHSA-hm7r-c7qw-ghp6.json Corrects the version range and adds supporting references.

Review effort: Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants